Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754777AbZKLWpf (ORCPT ); Thu, 12 Nov 2009 17:45:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754737AbZKLWpa (ORCPT ); Thu, 12 Nov 2009 17:45:30 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44827 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754731AbZKLWp3 (ORCPT ); Thu, 12 Nov 2009 17:45:29 -0500 Date: Thu, 12 Nov 2009 14:45:24 -0800 From: Andrew Morton To: "Stephen M. Cameron" Cc: James.Bottomley@HansenPartnership.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, mikem@beardog.cce.hp.com Subject: Re: [PATCH 04/17] Fix use of unallocated memory for MSA2xxx enclosure device data. Message-Id: <20091112144524.dc254708.akpm@linux-foundation.org> In-Reply-To: <20091111165043.17754.6076.stgit@beardog.cce.hp.com> References: <20091111164803.17754.11900.stgit@beardog.cce.hp.com> <20091111165043.17754.6076.stgit@beardog.cce.hp.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 682 Lines: 18 On Wed, 11 Nov 2009 10:50:43 -0600 "Stephen M. Cameron" wrote: > +#define MAX_MSA2XXX_ENCLOSURES 32 > + if (*nmsa2xxx_enclosures >= MAX_MSA2XXX_ENCLOSURES) { > + dev_warn(&h->pdev->dev, "Maximum number of MSA2XXX " > + "enclosures exceeded. Check your hardware " > + "configuration."); > + return 0; > + } The message would be a bit more helpful if it told the operator what the limit actually is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/