Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755996AbZKMAZH (ORCPT ); Thu, 12 Nov 2009 19:25:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755914AbZKMAZE (ORCPT ); Thu, 12 Nov 2009 19:25:04 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:41371 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755883AbZKMAZD (ORCPT ); Thu, 12 Nov 2009 19:25:03 -0500 Message-ID: <4AFCA75C.8000101@pobox.com> Date: Thu, 12 Nov 2009 19:25:00 -0500 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Mark Lord CC: Thiago Farina , Pekka Enberg , Bartlomiej Zolnierkiewicz , mlord@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: Clean up hard coded array size calculation. References: <1257708657-1232-1-git-send-email-tfransosi@gmail.com> <4AF8F363.3010806@rtr.ca> <200911101651.24912.bzolnier@gmail.com> <84144f020911100808y55f5bfa2v5c203b356583a7b5@mail.gmail.com> <4AFB3C9D.4020609@rtr.ca> <4AFC9FEC.8030304@rtr.ca> In-Reply-To: <4AFC9FEC.8030304@rtr.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 30 On 11/12/2009 06:53 PM, Mark Lord wrote: > Thiago Farina wrote: >> On Wed, Nov 11, 2009 at 8:37 PM, Mark Lord wrote: >>> Looks like unnecessary churn and obfuscation to me. >> >> Obfuscation? Are you saying that just because you wrote this code? So >> what is the usage of a macro? I think you are having a defensive >> position here. > .. > > No, actually I believe Jeff wrote that particular line of code. You know, Linus actually invented a command for people who enjoy this game... ;) git blame drivers/ata/sata_mv.c shows each line of code, and metadata about each line such as commit id and author name. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/