Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755239AbZKMBxx (ORCPT ); Thu, 12 Nov 2009 20:53:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755169AbZKMBxu (ORCPT ); Thu, 12 Nov 2009 20:53:50 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:45026 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755164AbZKMBxt (ORCPT ); Thu, 12 Nov 2009 20:53:49 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Fri, 13 Nov 2009 10:51:12 +0900 From: KAMEZAWA Hiroyuki To: Christoph Lameter Cc: Minchan Kim , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hugh.dickins@tiscali.co.uk" , akpm@linux-foundation.org, "kosaki.motohiro@jp.fujitsu.com" Subject: Re: [PATCH] show per-process swap usage via procfs v3 Message-Id: <20091113105112.c72cf8f5.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <20091104152426.eacc894f.kamezawa.hiroyu@jp.fujitsu.com> <28c262360911050711k47a63896xe4915157664cb822@mail.gmail.com> <20091106084806.7503b165.kamezawa.hiroyu@jp.fujitsu.com> <20091106134030.a94665d1.kamezawa.hiroyu@jp.fujitsu.com> <28c262360911060719y45f4b58ex2f13853f0d142656@mail.gmail.com> <20091111112539.71dfac31.kamezawa.hiroyu@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1652 Lines: 54 On Thu, 12 Nov 2009 10:20:29 -0500 (EST) Christoph Lameter wrote: > On Wed, 11 Nov 2009, KAMEZAWA Hiroyuki wrote: > > > > > Index: mm-test-kernel/include/linux/mm_types.h > > =================================================================== > > --- mm-test-kernel.orig/include/linux/mm_types.h > > +++ mm-test-kernel/include/linux/mm_types.h > > @@ -228,6 +228,7 @@ struct mm_struct { > > */ > > mm_counter_t _file_rss; > > mm_counter_t _anon_rss; > > + mm_counter_t _swap_usage; > > This is going to be another hit on vm performance if we get down this > road. > > At least put > > #ifdef CONFIG_SWAP ? > > around this so that we can switch it off? > Hmm, okay. But I'm not sure I can do it in clean way. (Or, I'll wait for you updates for mm_counters, or I do by myself.) > > @@ -597,7 +600,9 @@ copy_one_pte(struct mm_struct *dst_mm, s > > &src_mm->mmlist); > > spin_unlock(&mmlist_lock); > > } > > - if (is_write_migration_entry(entry) && > > + if (!non_swap_entry(entry)) > > + rss[2]++; > > + else if (is_write_migration_entry(entry) && > > is_cow_mapping(vm_flags)) { > > /* > > What are the implications for fork performance? This path is executed when page table entry contains a entry of !pte_none() && !pte_present(). There are not very big chance to reach here.(this path is under unlikely()). Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/