Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755667AbZKMJyN (ORCPT ); Fri, 13 Nov 2009 04:54:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755234AbZKMJyK (ORCPT ); Fri, 13 Nov 2009 04:54:10 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:56617 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754773AbZKMJyJ (ORCPT ); Fri, 13 Nov 2009 04:54:09 -0500 Date: Fri, 13 Nov 2009 10:52:49 +0100 From: Ingo Molnar To: Mike Travis Cc: Thomas Gleixner , Andrew Morton , Heiko Carstens , Roland Dreier , Randy Dunlap , Tejun Heo , Andi Kleen , Greg Kroah-Hartman , Yinghai Lu , "H. Peter Anvin" , David Rientjes , Steven Rostedt , Rusty Russell , Hidetoshi Seto , Jack Steiner , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] x86: Limit the number of processor bootup messages Message-ID: <20091113095249.GB1364@elte.hu> References: <20091112171934.584037000@alcatraz.americas.sgi.com> <20091112171942.423844000@alcatraz.americas.sgi.com> <20091112180910.GA8598@elte.hu> <4AFC6A6D.1040809@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AFC6A6D.1040809@sgi.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3384 Lines: 112 * Mike Travis wrote: > > > Ingo Molnar wrote: > >* Mike Travis wrote: > > > >>--- linux.orig/arch/x86/kernel/smpboot.c > >>+++ linux/arch/x86/kernel/smpboot.c > >>@@ -442,6 +442,84 @@ > >> return c->llc_shared_map; > >> } > >>+/* Summarize Processor Information */ > >>+static void __init summarize_cpu_info(void) > >>+{ > >>+ cpumask_var_t cpulist, cpusdone; > >>+ int cpu; > >>+ int err = 0; > >>+ > >>+ if (!alloc_cpumask_var(&cpulist, GFP_KERNEL)) > >>+ err = 1; > >>+ else if (!alloc_cpumask_var(&cpusdone, GFP_KERNEL)) { > >>+ free_cpumask_var(cpulist); > >>+ err = 1; > >>+ } > >>+ if (err) { > >>+ printk(KERN_INFO "Can't print processor summaries\n"); > >>+ return; > >>+ } > >>+ > >>+ cpumask_clear(cpusdone); > >>+ for (cpu = 0; cpu < nr_cpu_ids; cpu++) { > >>+ struct cpuinfo_x86 *c; > >>+ char buf[128]; > >>+ int ncpu, len; > >>+ unsigned long minlpj, maxlpj, avglpj = 0; > >>+ > >>+ /* skip if cpu has already been displayed */ > >>+ if (cpumask_test_cpu(cpu, cpusdone)) > >>+ continue; > >>+ > >>+ c = &cpu_data(cpu); > >>+ minlpj = ULONG_MAX; > >>+ maxlpj = 0; > >>+ > >>+ cpumask_clear(cpulist); > >>+ > >>+ /* collate all cpus with same specifics */ > >>+ for (ncpu = cpu; ncpu < nr_cpu_ids; ncpu++) { > >>+ struct cpuinfo_x86 *n = &cpu_data(ncpu); > >>+ > >>+ if (c->x86 != n->x86 || > >>+ c->x86_vendor != n->x86_vendor || > >>+ c->x86_model != n->x86_model || > >>+ c->x86_mask != n->x86_mask || > >>+ strcmp(c->x86_model_id, n->x86_model_id)) > >>+ continue; > >>+ > >>+ cpumask_set_cpu(ncpu, cpulist); > >>+ cpumask_set_cpu(ncpu, cpusdone); > >>+ > >>+ if (cpu_data(ncpu).loops_per_jiffy < minlpj) > >>+ minlpj = cpu_data(ncpu).loops_per_jiffy; > >>+ > >>+ if (cpu_data(ncpu).loops_per_jiffy > maxlpj) > >>+ maxlpj = cpu_data(ncpu).loops_per_jiffy; > >>+ > >>+ avglpj += cpu_data(ncpu).loops_per_jiffy; > >>+ } > >>+ > >>+ len = cpulist_scnprintf(buf, sizeof(buf), cpulist); > >>+ printk(KERN_INFO > >>+ "Processor Information for CPUS: %s%s\n", > >>+ buf, (len == sizeof(buf)-1) ? "..." : ""); > >>+ > >>+ printk(KERN_INFO); > >>+ print_cpu_info(c); > >>+ > >>+ avglpj /= cpumask_weight(cpulist); > >>+ printk(KERN_INFO "BogoMIPS: MIN %lu.%02lu (%lu) " > >>+ "AVG %lu.%02lu (%lu) MAX %lu.%02lu (%lu)\n", > >>+ minlpj/(500000/HZ), (minlpj/(5000/HZ)) % 100, minlpj, > >>+ avglpj/(500000/HZ), (avglpj/(5000/HZ)) % 100, avglpj, > >>+ maxlpj/(500000/HZ), (maxlpj/(5000/HZ)) % 100, maxlpj); > >>+ } > >>+ > >>+ free_cpumask_var(cpusdone); > >>+ free_cpumask_var(cpulist); > >>+} > >>+ > > > >Sigh, that's _way_ too complex. > > > >If you cannot print it in a summarized way without carrying over > >stupid state like bitmaps then please do the simple and obvious, > >and print: > > > >booting CPUs: #0 #1 #2 #3 #4 #5 #6 ... > > That is almost exactly what it does. [...] You are missing my point i think, which is that we dont want the 76 lines long summarize_cpu_info() complexity during bootup. Lets keep it _very_ simple and zap excessive messages - like DaveJ's patch did. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/