Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756706AbZKMSdS (ORCPT ); Fri, 13 Nov 2009 13:33:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755948AbZKMSdM (ORCPT ); Fri, 13 Nov 2009 13:33:12 -0500 Received: from mail-iw0-f178.google.com ([209.85.223.178]:53409 "EHLO mail-iw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754556AbZKMSdL convert rfc822-to-8bit (ORCPT ); Fri, 13 Nov 2009 13:33:11 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=IRRty2AnhBpnT9t8cOgzD1suPpRAyRakE/8vZu3gKLTaCBgh/kQJghqXSp1yPgEOon /gQlcJ3HDDnHkYcu6U/c2d2/ziZYMLYT4v05WHPBUIkFYXP+RHXUsC382kKRYQJ4hXII II9sr3/qLNRjA/xc/2TspO4dfJDuCJDSjFgq8= MIME-Version: 1.0 In-Reply-To: <20091113181557.GM29804@csn.ul.ie> References: <20091113142608.33B9.A69D9226@jp.fujitsu.com> <20091113135443.GF29804@csn.ul.ie> <20091114023138.3DA5.A69D9226@jp.fujitsu.com> <20091113181557.GM29804@csn.ul.ie> Date: Sat, 14 Nov 2009 03:33:16 +0900 X-Google-Sender-Auth: 9e621a805d035b55 Message-ID: <2f11576a0911131033w4a9e6042k3349f0be290a167e@mail.gmail.com> Subject: Re: [PATCH] vmscan: Stop kswapd waiting on congestion when the min watermark is not being met From: KOSAKI Motohiro To: Mel Gorman Cc: Andrew Morton , Frans Pop , Jiri Kosina , Sven Geggus , Karol Lewandowski , Tobias Oetiker , linux-kernel@vger.kernel.org, "linux-mm@kvack.org" , Pekka Enberg , Rik van Riel , Christoph Lameter , Stephan von Krawczynski , "Rafael J. Wysocki" , Kernel Testers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 21 > @@ -2092,8 +2102,12 @@ loop_again: > ? ? ? ? ? ? ? ? * OK, kswapd is getting into trouble. ?Take a nap, then take > ? ? ? ? ? ? ? ? * another pass across the zones. > ? ? ? ? ? ? ? ? */ > - ? ? ? ? ? ? ? if (total_scanned && priority < DEF_PRIORITY - 2) > - ? ? ? ? ? ? ? ? ? ? ? congestion_wait(BLK_RW_ASYNC, HZ/10); > + ? ? ? ? ? ? ? if (total_scanned && (priority < DEF_PRIORITY - 2)) { > + ? ? ? ? ? ? ? ? ? ? ? if (!has_under_min_watermark_zone) if I am correct, we must to remove "!". > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? count_vm_event(KSWAPD_NO_CONGESTION_WAIT); > + ? ? ? ? ? ? ? ? ? ? ? else > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? congestion_wait(BLK_RW_ASYNC, HZ/10); > + ? ? ? ? ? ? ? } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/