Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932566AbZKMXJb (ORCPT ); Fri, 13 Nov 2009 18:09:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932560AbZKMXJ3 (ORCPT ); Fri, 13 Nov 2009 18:09:29 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:43317 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932474AbZKMXJ2 (ORCPT ); Fri, 13 Nov 2009 18:09:28 -0500 Date: Fri, 13 Nov 2009 15:09:04 -0800 From: Andrew Morton To: Masami Hiramatsu Cc: Ingo Molnar , lkml , systemtap , DLE , Hidehiro Kawai , Oleg Nesterov , Roland McGrath Subject: Re: [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency Message-Id: <20091113150904.56c15910.akpm@linux-foundation.org> In-Reply-To: <20091113225226.15079.90813.stgit@harusame> References: <20091113225226.15079.90813.stgit@harusame> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 20 On Fri, 13 Nov 2009 17:52:27 -0500 Masami Hiramatsu wrote: > Pass mm->flags to binfmt core_dump for bitflag consistency. > Since mm->flags bit flags is not protected by locks, it will be > changed while dumping core. This patch copies mm->flags to a > mm_flags local variable at the beginning of do_coredump() and > use it while dumping. mm_flags also includes dump_filter which > filters elf sections from core file in elf_core_dump(). > So, this patch also passes mm_flags to each binfmt->core_dump(). I can kind-of guess the answer, but it would be much more reliable if we were to hear this from yourself: Why did you write this patch? What problem is being observed? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/