Subject: Re: [PATCH 2.6.32] ftrace: fix event format export
From: Steven Rostedt <rostedt@goodmis.org>
Reply-To: rostedt@goodmis.org
To: Ingo Molnar <mingo@elte.hu>
Cc: Johannes Berg <johannes@sipsolutions.net>,
       Fr??d??ric Weisbecker <fweisbec@gmail.com>,
       Thomas Gleixner <tglx@linutronix.de>,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20091113224009.GB23942@elte.hu>
References: <1258115870.6167.4.camel@johannes.local>
	 <20091113224009.GB23942@elte.hu>
Content-Type: text/plain
Organization: Kihon Technologies Inc.
Date: Fri, 13 Nov 2009 18:28:29 -0500
Message-Id: <1258154909.22249.211.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1139
Lines: 41

On Fri, 2009-11-13 at 23:40 +0100, Ingo Molnar wrote:
> ( extended the Cc:s. Please try to Cc: people you think would be 
>   interested in your patches. )

Thanks Ingo.

> 
> * Johannes Berg <johannes@sipsolutions.net> wrote:
> 
> > For some reason the export of the event print
> > format to userspace uses '#fmt' which breaks
> > if the format string is anything but a plain
> > string, for example if it is built with macros
> > then the macro names are exported instead of
> > their contents.
> > 
> > Use
> > 	"\"%s\"", fmt
> > instead of
> > 	"%s", #fmt
> > to export the string and not the way it is built.

Is there any examples of this currently in the kernel? If so could you
show that in the changlog.

But other than that, the change looks good.

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> > 
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > ---


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/