MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
       systemtap <systemtap@sources.redhat.com>,
       DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [PATCH -tip 3/3] Add get_signal tracepoint
In-Reply-To: Masami Hiramatsu's message of  Friday, 13 November 2009 17:52:40 -0500 <20091113225240.15079.4863.stgit@harusame>
References: <20091113225226.15079.90813.stgit@harusame>
	<20091113225240.15079.4863.stgit@harusame>
Emacs: because extension languages should come with the editor built in.
Message-Id: <20091113235333.0E3CC15E8@magilla.sf.frob.com>
Date: Fri, 13 Nov 2009 15:53:33 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1181
Lines: 27

This is orthogonal to the core-dump tracepoint, I don't see why you
call them a unified patch series.

The proper name for this event is "signal delivery".  But since the
proper name for "send_signal" is "signal generation", I suppose "get"
is analogously improper to the existing "send" tracepoint.  ;-)

Especially if you call this "get" rather than "deliver", there is
another place that should invoke this tracepoint (or perhaps a third
one).  sys_rt_sigtimedwait "gets" a signal without delivering it.  In
POSIX terminology this is called "accepting" the signal: the three
things that can happen in the life of a signal are "generate",
"deliver", and "accept".  If you are trying to match up what happened to
a signal generated by kill() or whatnot, then you want to notice both
delivery and acceptance as the complementary event.

(And again I have no clue why this signal stuff should be called
"sched" at all.)


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/