DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=eYB70kx2kDpNpAADRJHUVC1nj3bhRzjnOav2B4KYVb3I3I6J/1LBjh962IZ3BNv0Nf
         zKcLsEHdJUbtp0a6wPLpT2G7ROuuSR8oZWU1D9+WzEge2q6MM7B9azUqMR0vxqtzzn2Z
         E5IVlDkWnrHe/ojCDJ0LoeffLD9bGw0AJzajw=
MIME-Version: 1.0
In-Reply-To: <1257195888-6122-1-git-send-email-tfransosi@gmail.com>
References: <1257195888-6122-1-git-send-email-tfransosi@gmail.com>
From: Mike Frysinger <vapier.adi@gmail.com>
Date: Sat, 14 Nov 2009 21:52:36 -0500
Message-ID: <8bd0f97a0911141852x33dedba8g7d3c3b134ff654b@mail.gmail.com>
Subject: Re: [PATCH] blackfin/trivial: remove duplicated MAX macro from stamp.
To: Thiago Farina <tfransosi@gmail.com>
Cc: trivial@kernel.org, cooloney@kernel.org, michael.hennerich@analog.com,
       barry.song@analog.com, yi.li@analog.com,
       uclinux-dist-devel@blackfin.uclinux.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1271
Lines: 28

On Mon, Nov 2, 2009 at 16:04, Thiago Farina wrote:
> Since the kernel api already has the macro "max",
> just use it instead of declaring another one.
>
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -385,10 +385,9 @@ static struct platform_nand_data bfin_plat_nand_data = {
>        },
>  };
>
> -#define MAX(x, y) (x > y ? x : y)
>  static struct resource bfin_plat_nand_resources = {
>        .start = 0x20212000,
> -       .end   = 0x20212000 + (1 << MAX(BFIN_NAND_PLAT_CLE, BFIN_NAND_PLAT_ALE)),
> +       .end   = 0x20212000 + (1 << max(BFIN_NAND_PLAT_CLE, BFIN_NAND_PLAT_ALE)),

sorry, going to have to reject this.  the common min/max defines are
not usable in this context.  this patch produces a build failure:
  CC      arch/blackfin/mach-bf537/boards/stamp.o
arch/blackfin/mach-bf537/boards/stamp.c:430: error: braced-group
within expression allowed only inside a function
make[1]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/