Subject: Re: [PATCH] procfs: Use proper units for noMMU statm
From: "Steven J. Magnani" <steve@digidescorp.com>
Reply-To: steve@digidescorp.com
To: =?ISO-8859-1?Q?Am=E9rico?= Wang <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20091114044153.GB2416@hack>
References: <1258163534-3617-1-git-send-email-steve@digidescorp.com>
	 <20091114044153.GB2416@hack>
Content-Type: text/plain; charset="UTF-8"
Organization: Digital Design Corporation
Date: Mon, 16 Nov 2009 08:47:33 -0600
Message-Id: <1258382853.3019.0.camel@iscandar.digidescorp.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1138
Lines: 29

On Sat, 2009-11-14 at 12:41 +0800, Américo Wang wrote:
> On Fri, Nov 13, 2009 at 07:52:14PM -0600, steve@digidescorp.com wrote:
> >On no-MMU systems, sizes reported in /proc/n/statm have units of bytes. 
> >Per Documentation/filesystems/proc.txt, these values should be in pages.
> >
> > ...
> >
> >+	*data = (mm->start_stack - mm->start_data) >> PAGE_SHIFT;
> 
> Are '->start_stack' and '->start_data' already page aligned on NOMMU arch?
> 

In looking over binfmt_flat.c (main executable type for noMMU systems),
I don't think there's a guarantee of more than 32- or 64-bit alignment.
Thanks for the suggestion, I'll submit an updated patch.

------------------------------------------------------------------------
 Steven J. Magnani               "I claim this network for MARS!
 www.digidescorp.com              Earthling, return my space modulator!"

 #include <standard.disclaimer>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/