Message-ID: <4B019FC9.4080309@kernel.org>
Date: Tue, 17 Nov 2009 03:54:01 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>
CC: linux-kernel@vger.kernel.org, jeff@garzik.org, mingo@elte.hu,
       akpm@linux-foundation.org, jens.axboe@oracle.com, rusty@rustcorp.com.au,
       cl@linux-foundation.org, dhowells@redhat.com, arjan@linux.intel.com,
       torvalds@linux-foundation.org, avi@redhat.com, andi@firstfloor.org,
       fweisbec@gmail.com
Subject: Re: [PATCH 04/21] sched: implement scheduler notifiers
References: <1258391726-30264-1-git-send-email-tj@kernel.org>	 <1258391726-30264-5-git-send-email-tj@kernel.org> <1258396864.4372.55.camel@twins>
In-Reply-To: <1258396864.4372.55.camel@twins>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 858
Lines: 25

Peter Zijlstra wrote:
> I really hate exposing activate/deactivate.
> 
> You say:
> 
>> Activated and deactivated are called
>> when a task's readiness to run changes.
> 
> How is that not clear from the out hook? It would seem to me that when
> you get scheduled out with a p->state != TASK_RUNNING you're not ready.

In that in OUT hook the next task to switch to is already determined
and it wouldn't be symmetric with activate (but I suppose we can match
the symmetry from activate side).  If deactivate/activate/in/out
events are too low level, we can have sleep/ready/run hooks instead.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/