Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754131AbZKPVFm (ORCPT ); Mon, 16 Nov 2009 16:05:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754115AbZKPVFm (ORCPT ); Mon, 16 Nov 2009 16:05:42 -0500 Received: from casper.infradead.org ([85.118.1.10]:53643 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753867AbZKPVFl (ORCPT ); Mon, 16 Nov 2009 16:05:41 -0500 Subject: Re: [PATCH 5/5] perf buildid-list: New plumbing command From: Peter Zijlstra To: Arnaldo Carvalho de Melo Cc: Frederic Weisbecker , Ingo Molnar , linux-kernel@vger.kernel.org, Mike Galbraith , Paul Mackerras In-Reply-To: <20091116194104.GC12042@ghostprotocols.net> References: <1258396365-29217-1-git-send-email-acme@infradead.org> <1258396365-29217-2-git-send-email-acme@infradead.org> <1258396365-29217-3-git-send-email-acme@infradead.org> <1258396365-29217-4-git-send-email-acme@infradead.org> <1258396365-29217-5-git-send-email-acme@infradead.org> <20091116185850.GB5293@nowhere> <20091116194104.GC12042@ghostprotocols.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 16 Nov 2009 22:05:33 +0100 Message-ID: <1258405533.3961.60.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1818 Lines: 40 On Mon, 2009-11-16 at 17:41 -0200, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 16, 2009 at 07:58:52PM +0100, Frederic Weisbecker escreveu: > > On Mon, Nov 16, 2009 at 04:32:45PM -0200, Arnaldo Carvalho de Melo wrote: > > > With this we can list the buildids in a perf.data file so that we can > > > pipe them to other, distro specific tools that from the buildids can > > > figure out separate packages (foo-debuginfo) where we can find the > > > matching symtabs so that perf report can do its job. > > > E.g: > > > [acme@doppio linux-2.6-tip]$ perf buildid-list | head -2 > > > 8e08b117e5458ad3f85da16d42d0fc5cd21c5869 > > > 520c2387a587cc5acfcf881e27dba1caaeab4b1f > > > [acme@doppio linux-2.6-tip]$ perf buildid-list -v | head -2 > > > 8e08b117e5458ad3f85da16d42d0fc5cd21c5869 /sbin/init > > > 520c2387a587cc5acfcf881e27dba1caaeab4b1f /lib64/ld-2.10.1.so > > > > I would rather see the effect of this -v option as the default. > > It's very useful to see the dso resolved but hashes alone > > don't pay much. > > I disagree, the main purpose of this command is equivalent to 'git > rev-list': > > [acme@doppio linux-2.6-tip]$ git rev-list HEAD^^.. > 089242a8c826aac1c827bb797475b9852fe0db49 > 18e3a75dc47d8397bbf0936ec8e3ebdecada7ba1 > [acme@doppio linux-2.6-tip]$ > > I.e. provide content keys that then will be used by distro specific > porcelain to get the matching -debuginfo packages with the symtabs. I'm pretty sure such distro specific muck can trivially ignore the second column. And the output is much _much_ more useful when it has the dso listed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/