Message-ID: <4B01C03C.6000309@oracle.com>
Date: Mon, 16 Nov 2009 13:12:28 -0800
From: Zach Brown <zach.brown@oracle.com>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: Shaohua Li <shaohua.li@intel.com>, linux-kernel@vger.kernel.org,
       bcrl@kvack.org, Jeff Moyer <jmoyer@redhat.com>,
       David Brownell <dbrownell@users.sourceforge.net>,
       linux-usb@vger.kernel.org
Subject: Re: [PATCH]aio: remove unused field
References: <20091112075247.GA17960@sli10-desk.sh.intel.com> <20091113143408.c7965e74.akpm@linux-foundation.org>
In-Reply-To: <20091113143408.c7965e74.akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 832
Lines: 22


> If we do this then kick_iocb() has only one in-kernel caller, in
> drivers/usb/gadget/inode.c.  I wonder if the gadget code really needs
> to be using kick_iocb()?

I don't think that it needs to, no.  It's only using the aio retry
functionality to perform a copy of read data into user space.

I have a patch to switch it to using schedule_work() instead:

  http://marc.info/?l=linux-fsdevel&m=125624446623075&w=2

I've been focusing on other things instead of pushing that to the usb
folks to be tested and merged, though.  I've cc:ed them in case they
want to run with this.

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/