Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754114AbZKQDRz (ORCPT ); Mon, 16 Nov 2009 22:17:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753993AbZKQDRx (ORCPT ); Mon, 16 Nov 2009 22:17:53 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:50935 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbZKQDRw (ORCPT ); Mon, 16 Nov 2009 22:17:52 -0500 Message-ID: <4B0215E3.2020400@pobox.com> Date: Mon, 16 Nov 2009 22:17:55 -0500 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Thiago Farina CC: mlord@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: Clean up hard coded array size calculation. References: <1257708657-1232-1-git-send-email-tfransosi@gmail.com> In-Reply-To: <1257708657-1232-1-git-send-email-tfransosi@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 28 On 11/08/2009 02:30 PM, Thiago Farina wrote: > Use ARRAY_SIZE macro of kernel api instead. > > Signed-off-by: Thiago Farina > --- > drivers/ata/sata_mv.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c > index 6f5093b..a8a7be0 100644 > --- a/drivers/ata/sata_mv.c > +++ b/drivers/ata/sata_mv.c > @@ -2217,7 +2217,7 @@ static unsigned int mv_qc_issue_fis(struct ata_queued_cmd *qc) > int err = 0; > > ata_tf_to_fis(&qc->tf, link->pmp, 1, (void *)fis); > - err = mv_send_fis(ap, fis, sizeof(fis) / sizeof(fis[0])); > + err = mv_send_fis(ap, fis, ARRAY_SIZE(fis)); > if (err) applied -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/