Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754798AbZKQKiA (ORCPT ); Tue, 17 Nov 2009 05:38:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754633AbZKQKh7 (ORCPT ); Tue, 17 Nov 2009 05:37:59 -0500 Received: from smtp-out003.kontent.com ([81.88.40.217]:35833 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753150AbZKQKh7 (ORCPT ); Tue, 17 Nov 2009 05:37:59 -0500 From: Oliver Neukum To: Minchan Kim Subject: Re: [PATCH 2/7] mmc: Don't use PF_MEMALLOC Date: Tue, 17 Nov 2009 11:38:02 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.32-rc6-0.1-default; KDE/4.3.1; x86_64; ; ) Cc: Alan Cox , KOSAKI Motohiro , LKML , "linux-mm" , Andrew Morton , linux-mmc@vger.kernel.org References: <20091117161551.3DD4.A69D9226@jp.fujitsu.com> <20091117102903.7cb45ff3@lxorguk.ukuu.org.uk> <28c262360911170232i307144cnb4ddea2a5389bd8e@mail.gmail.com> In-Reply-To: <28c262360911170232i307144cnb4ddea2a5389bd8e@mail.gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200911171138.02458.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 29 Am Dienstag, 17. November 2009 11:32:36 schrieb Minchan Kim: > On Tue, Nov 17, 2009 at 7:29 PM, Alan Cox wrote: > > On Tue, 17 Nov 2009 16:17:50 +0900 (JST) > > > > KOSAKI Motohiro wrote: > >> Non MM subsystem must not use PF_MEMALLOC. Memory reclaim need few > >> memory, anyone must not prevent it. Otherwise the system cause > >> mysterious hang-up and/or OOM Killer invokation. > > > > So now what happens if we are paging and all our memory is tied up for > > writeback to a device or CIFS etc which can no longer allocate the memory > > to complete the write out so the MM can reclaim ? > > > > Am I missing something or is this patch set not addressing the case where > > the writeback thread needs to inherit PF_MEMALLOC somehow (at least for > > the I/O in question and those blocking it) > > I agree. > At least, drivers for writeout is proper for using PF_MEMALLOC, I think. For the same reason error handling should also use it, shouldn't it? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/