Message-ID: <4B02961F.8020108@draigBrady.com>
Date: Tue, 17 Nov 2009 12:25:03 +0000
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Thunderbird 2.0.0.6 (X11/20071008)
MIME-Version: 1.0
To: Roel Kluin <roel.kluin@gmail.com>
CC: Randy Dunlap <rdunlap@xenotime.net>, linux-doc@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>,
       LKML <linux-kernel@vger.kernel.org>, David Wagner <daw@cs.berkeley.edu>
Subject: Re: [PATCH] Documentation: Fix NUL termination of strncpy
References: <4B018405.2030408@gmail.com> <4B019F52.50509@gmail.com>
In-Reply-To: <4B019F52.50509@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 28

Roel Kluin wrote:
> Ensure the copied strings are NUL terminated.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
>> Rationale (please correct me if I'm wrong):
> 
> diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c
> index 6e25c26..4d71b0e 100644
> --- a/Documentation/accounting/getdelays.c
> +++ b/Documentation/accounting/getdelays.c
> @@ -303,7 +303,7 @@ int main(int argc, char *argv[])
>  				err(1, "Invalid rcv buf size\n");
>  			break;
>  		case 'm':
> -			strncpy(cpumask, optarg, sizeof(cpumask));
> +			strncpy(cpumask, optarg, sizeof(cpumask) - 1);

You need to explicitly NUL terminate strncpy():
http://www.pixelbeat.org/programming/gcc/string_buffers.html

cheers,
P?draig.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/