Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823AbZKQVhI (ORCPT ); Tue, 17 Nov 2009 16:37:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753343AbZKQVhI (ORCPT ); Tue, 17 Nov 2009 16:37:08 -0500 Received: from mga09.intel.com ([134.134.136.24]:25630 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753159AbZKQVhH (ORCPT ); Tue, 17 Nov 2009 16:37:07 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,760,1249282800"; d="scan'208";a="468179037" Date: Tue, 17 Nov 2009 13:37:12 -0800 From: "Pallipadi, Venkatesh" To: Justin Piszcz Cc: "Pallipadi, Venkatesh" , Thomas Gleixner , john stultz , lkml , Arjan van de Ven Subject: Re: 2.6.31.4: WARNING: at arch/x86/kernel/hpet.c:390 hpet_next_event+0x70/0x80() [occurs when ACPI_PROCESSOR=y] Message-ID: <20091117213711.GA19132@linux-os.sc.intel.com> References: <1258069232.14894.9.camel@localhost.localdomain> <7E82351C108FA840AB1866AC776AEC467647ABBD@orsmsx505.amr.corp.intel.com> <1258137165.21141.20.camel@localhost.localdomain> <1258161139.21141.29.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2078 Lines: 59 On Tue, Nov 17, 2009 at 03:45:31AM -0800, Justin Piszcz wrote: > > > On Sat, 14 Nov 2009, Justin Piszcz wrote: > > > > > > > On Fri, 13 Nov 2009, Pallipadi, Venkatesh wrote: > > > >> On Fri, 2009-11-13 at 10:43 -0800, Justin Piszcz wrote: > >>> > >>> On Fri, 13 Nov 2009, Pallipadi, Venkatesh wrote: > >>> > >>>> On Fri, 2009-11-13 at 01:38 -0800, Thomas Gleixner wrote: > >>>>> On Thu, 12 Nov 2009, Pallipadi, Venkatesh wrote: > >>>>>> Yes. Yes. This is a hardware errata. I have a patch to workaround this > >>>>>> and > >>>>>> waiting on the errata description to get published.. > > 1. Do we have an ETA of when this will get published? > 2. Is there a patch available for testing? Unfortunately, I don't have an ETA for when the errata will be published. I am still stuck up on what is the original problem you have without the patch on vanilla kernel? You will see the WARNING in the dmesg. As I understand, that should not prevent you from loading processor driver or getting the turbo boost or anything like that. The warning is a one time info and timer and ACPI P/C states should work just fine. Anyways, below is the patch that you can use for testing. --- arch/x86/kernel/hpet.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index dedc2bd..6beb5b5 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -387,7 +387,8 @@ static int hpet_next_event(unsigned long delta, * what we wrote hit the chip before we compare it to the * counter. */ - WARN_ON_ONCE((u32)hpet_readl(HPET_Tn_CMP(timer)) != cnt); + if (unlikely((u32)hpet_readl(HPET_Tn_CMP(timer)) != cnt)) + WARN_ON_ONCE((u32)hpet_readl(HPET_Tn_CMP(timer)) != cnt); return (s32)((u32)hpet_readl(HPET_COUNTER) - cnt) >= 0 ? -ETIME : 0; } -- 1.6.0.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/