Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756432AbZKQW3N (ORCPT ); Tue, 17 Nov 2009 17:29:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756417AbZKQW3M (ORCPT ); Tue, 17 Nov 2009 17:29:12 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:38603 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756416AbZKQW3J (ORCPT ); Tue, 17 Nov 2009 17:29:09 -0500 From: "Rafael J. Wysocki" To: Arkadiusz Miskiewicz Subject: Re: [Bug #14380] Video tearing/glitching with T400 laptops Date: Tue, 17 Nov 2009 23:30:42 +0100 User-Agent: KMail/1.12.3 (Linux/2.6.32-rc7-rjw; KDE/4.3.3; x86_64; ; ) Cc: Linux Kernel Mailing List , Kernel Testers List , "Jesse Barnes" , "Theodore Ts'o" References: <200911171352.18563.a.miskiewicz@gmail.com> In-Reply-To: <200911171352.18563.a.miskiewicz@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <200911172330.42494.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2141 Lines: 48 On Tuesday 17 November 2009, Arkadiusz Miskiewicz wrote: > On Monday 16 of November 2009, Rafael J. Wysocki wrote: > > This message has been generated automatically as a part of a report > > of recent regressions. > > > > The following bug entry is on the current list of known regressions > > from 2.6.31. Please verify if it still should be listed and let me know > > (either way). > > It's mostly gone. It still happens for like 1/4s once per 6hours but jbarnes > asked me to fill separate bug for that and gave such patch for testing (see below). > > So far haven't seen 1/4s problem with this patch applied. Great. > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 3ba6546..b2cbf7f 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -2491,6 +2491,8 @@ static void g4x_update_wm(struct drm_device *dev, int planea_clock, > /* Use ns/us then divide to preserve precision */ > sr_entries = (((sr_latency_ns / line_time_us) + 1) * > pixel_size * sr_hdisplay) / 1000; > + if (sr_entries > G4X_FIFO_SIZE) > + sr_entries = G4X_FIFO_SIZE; > sr_entries = roundup(sr_entries / cacheline_size, 1); > DRM_DEBUG("self-refresh entries: %d\n", sr_entries); > I915_WRITE(FW_BLC_SELF, FW_BLC_SELF_EN); > > > > > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14380 > > Subject : Video tearing/glitching with T400 laptops > > Submitter : Theodore Ts'o > > Date : 2009-10-02 22:40 (46 days old) > > References : http://marc.info/?l=linux-kernel&m=125452324520623&w=4 > > Handled-By : Jesse Barnes > > Patch : http://marc.info/?l=linux-kernel&m=125591495325000&w=4 Thanks for the update. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/