Date: Tue, 17 Nov 2009 19:44:01 -0800
From: Greg KH <gregkh@suse.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Johan Hovold <jhovold@gmail.com>,
       Michael Trimarchi <trimarchi@gandalf.sssup.it>,
       linux-usb@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       linux-kernel@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
       Oliver Neukum <oliver@neukum.org>
Subject: Re: [PATCH] ftdi_sio:  Keep going when write errors are
 encountered.
Message-ID: <20091118034401.GA17349@suse.de>
References: <20090924154023.GA27480@localhost>
 <20091003140902.38628d8a@lxorguk.ukuu.org.uk>
 <m13a4df19g.fsf@fess.ebiederm.org>
 <200911171941.34781.oliver@neukum.org>
 <m1lji4od0k.fsf@fess.ebiederm.org>
 <m1fx8co7d3.fsf_-_@fess.ebiederm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m1fx8co7d3.fsf_-_@fess.ebiederm.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 906
Lines: 22

On Tue, Nov 17, 2009 at 07:10:48PM -0800, Eric W. Biederman wrote:
> 
> The use of urb->actual_length to update tx_outstanding_bytes
> implicitly assumes that the number of bytes actually written is the
> same as the number of bytes we tried to write.  On error that
> assumption is violated so just use transfer_buffer_length the number
> of bytes we intended to write to the device.
> 
> If an error occurs we need to fall through and call
> usb_serial_port_softint to wake up processes waiting in
> tty_wait_until_sent.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>

Nice job, thanks for debugging this.  I'll go queue it up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/