Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756737AbZKRERo (ORCPT ); Tue, 17 Nov 2009 23:17:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756398AbZKRERn (ORCPT ); Tue, 17 Nov 2009 23:17:43 -0500 Received: from g4t0014.houston.hp.com ([15.201.24.17]:5560 "EHLO g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753818AbZKRERn (ORCPT ); Tue, 17 Nov 2009 23:17:43 -0500 Date: Tue, 17 Nov 2009 21:17:48 -0700 From: Alex Chiang To: Dave Jones , linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org Subject: Re: [PATCH 1/3] [CPUFREQ] make ACPI P-state cpufreq drivers depend on CONFIG_CPU_FREQ Message-ID: <20091118041748.GC6648@ldl.fc.hp.com> References: <20091117220729.25933.57884.stgit@bob.kio> <20091117221120.25933.46929.stgit@bob.kio> <20091118000817.GA1855@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091118000817.GA1855@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 50 * Dave Jones : > > > diff --git a/arch/x86/kernel/cpu/cpufreq/Kconfig b/arch/x86/kernel/cpu/cpufreq/Kconfig > > index f138c6c..ca40a9f 100644 > > --- a/arch/x86/kernel/cpu/cpufreq/Kconfig > > +++ b/arch/x86/kernel/cpu/cpufreq/Kconfig > > @@ -13,7 +13,7 @@ comment "CPUFreq processor drivers" > > config X86_ACPI_CPUFREQ > > tristate "ACPI Processor P-States driver" > > select CPU_FREQ_TABLE > > - depends on ACPI_PROCESSOR > > + depends on ACPI_PROCESSOR && CPU_FREQ > > help > > This driver adds a CPUFreq driver which utilizes the ACPI > > Processor Performance States. > > @@ -69,7 +69,7 @@ config X86_POWERNOW_K6 > > config X86_POWERNOW_K7 > > tristate "AMD Mobile Athlon/Duron PowerNow!" > > select CPU_FREQ_TABLE > > - depends on X86_32 > > + depends on X86_32 && CPU_FREQ > > help > > This adds the CPUFreq driver for mobile AMD K7 mobile processors. > > > > @@ -87,7 +87,7 @@ config X86_POWERNOW_K7_ACPI > > config X86_POWERNOW_K8 > > tristate "AMD Opteron/Athlon64 PowerNow!" > > select CPU_FREQ_TABLE > > - depends on ACPI && ACPI_PROCESSOR > > + depends on ACPI && ACPI_PROCESSOR && CPU_FREQ > > help > > This adds the CPUFreq driver for K8/K10 Opteron/Athlon64 processors. > > This doesn't make sense, as this whole file is guarded with > > if CPU_FREQ > ... > endif > > The dependancy has to be true, or you wouldn't ever see these options. Yes, sorry, you're right. Apologies for the noise. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/