From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Steve French <smfrench@gmail.com>
Subject: Re: [PATCH 6/7] cifs: Don't use PF_MEMALLOC
Cc: kosaki.motohiro@jp.fujitsu.com, Jeff Layton <jlayton@redhat.com>,
       LKML <linux-kernel@vger.kernel.org>, samba-technical@lists.samba.org,
       Steve French <sfrench@samba.org>, linux-mm <linux-mm@kvack.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       linux-cifs-client@lists.samba.org
In-Reply-To: <524f69650911170840o5be241a0q5d9863c8d7f4e571@mail.gmail.com>
References: <20091117074739.4abaef85@tlielax.poochiereds.net> <524f69650911170840o5be241a0q5d9863c8d7f4e571@mail.gmail.com>
Message-Id: <20091118152007.3E1D.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Wed, 18 Nov 2009 15:31:19 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 22

> It is hard to follow exactly what this flag does in /mm (other than try
> harder on memory allocations) - I haven't found much about this flag (e.g.
> http://lwn.net/Articles/246928/) but it does look like most of the fs no
> longer set this (except xfs) e.g. ext3_ordered_writepage.  When running out
> of memory in the cifs_demultiplex_thread it will retry 3 seconds later, but
> if memory allocations ever fail in this path we could potentially be holding
> up (an already issued write in) writepages for that period by not having
> memory to get the response to see if the write succeeded.
> 
> We pass in few flags for these memory allocation requests: GFP_NOFS (on the
> mempool_alloc) and SLAB_HWCACHE_ALIGN (on the kmem_cache_create of the pool)
> should we be passing in other flags on the allocations?

I don't think you  need change more.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/