To: Li Yang <leoli@freescale.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gregkh@suse.de
Subject: Re: [RFC] char/mem: Honor O_SYNC over intelligent setting of uncached access
From: Andi Kleen <andi@firstfloor.org>
References: <1258531548-5015-1-git-send-email-leoli@freescale.com>
Date: Wed, 18 Nov 2009 11:41:01 +0100
In-Reply-To: <1258531548-5015-1-git-send-email-leoli@freescale.com> (Li Yang's message of "Wed, 18 Nov 2009 16:05:48 +0800")
Message-ID: <873a4c5d4y.fsf@basil.nowhere.org>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1066
Lines: 26

Li Yang <leoli@freescale.com> writes:

D> The original code will automatially set the page non-cacheable if the mmap'ped
> address is not in kernel managed low memory.
>
> We already have O_SYNC flag to pass the cacheability settings.   Therefore we should
> honor the case that O_SYNC is delibrately not used.  For example, it is useful to the
> case that not all system memory is managed by Linux, and want to be mmaped cacheable.
>
> Not sure if there is anything out there depending on the previous behavior.

Very likely there is. That change seems rather dangerous.

If you wanted to do something like this you would need a long 
deprecation period with printks and format warnings. But most likely
it's not worth it, what advantage does the change have?

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/