Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932150AbZKRSHB (ORCPT ); Wed, 18 Nov 2009 13:07:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758030AbZKRSHA (ORCPT ); Wed, 18 Nov 2009 13:07:00 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:56254 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757997AbZKRSHA (ORCPT ); Wed, 18 Nov 2009 13:07:00 -0500 From: Arnd Bergmann To: Alan Cox Subject: Re: [PATCH 1/2] BKL: Remove BKL from default_llseek() Date: Wed, 18 Nov 2009 19:06:59 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic; KDE/4.3.2; x86_64; ; ) Cc: Jamie Lokier , Jan Blunck , linux-fsdevel@vger.kernel.org, "Linux-Kernel Mailinglist" , Andrew Morton , jkacur@redhat.com, Thomas Gleixner , Christoph Hellwig , =?iso-8859-1?q?Fr=E9d=E9ric_Weisbecker?= , Alexander Viro References: <1258560457-15129-1-git-send-email-jblunck@suse.de> <200911181833.37531.arnd@arndb.de> <20091118180044.3d5981bf@lxorguk.ukuu.org.uk> In-Reply-To: <20091118180044.3d5981bf@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200911181906.59367.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX19ahD9PckgapOjLzTBEl1DZsnTU+LF+KeO8efh AKKQZ111sxaWnPpgJaZJizG3OCKI+ptnNhnltG7nd4dFRV/tGq ru7VP/yvngoKaXcDh4L9w== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 19 On Wednesday 18 November 2009, Alan Cox wrote: > > There are drivers touching f_pos in ioctl() methods, which is vaguely > > reasonable. There are also driver touching it in their read()/write() > > methods, which has no effect whatsoever. > > osst is the obvious offender. The ioctl ones like mtdchar seem to be > broken but they have their own locking (or lack thereof) in there own > lseek so its an internal proble,. > The other ones I found before giving up are drivers/s390/char/tape_char.c and drivers/sbus/char/flash.c. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/