Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758197AbZKRSPu (ORCPT ); Wed, 18 Nov 2009 13:15:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758169AbZKRSPt (ORCPT ); Wed, 18 Nov 2009 13:15:49 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:43569 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758064AbZKRSPs (ORCPT ); Wed, 18 Nov 2009 13:15:48 -0500 Date: Wed, 18 Nov 2009 18:17:12 +0000 From: Alan Cox To: Jan Blunck Cc: linux-fsdevel@vger.kernel.org, Linux-Kernel Mailinglist , Andrew Morton , jkacur@redhat.com, Thomas Gleixner , Arnd Bergmann , Christoph Hellwig , =?ISO-8859-14?B?RnLpZOlyaWM=?= Weisbecker , Alexander Viro Subject: Re: [PATCH 1/2] BKL: Remove BKL from default_llseek() Message-ID: <20091118181712.14a2404c@lxorguk.ukuu.org.uk> In-Reply-To: <20091118175307.GQ21750@bolzano.suse.de> References: <1258560457-15129-1-git-send-email-jblunck@suse.de> <20091118171524.4d2f8cec@lxorguk.ukuu.org.uk> <20091118175307.GQ21750@bolzano.suse.de> X-Mailer: Claws Mail 3.7.3 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 14 > As I said, f_pos is changed without holding BKL in the VFS already. Therefore IFF the VFS paths that change it can be invoked in parallel. > even if the driver tries to protect f_pos by holding the BKL it is racing > against concurrent read()/write() anyway on f_pos. It may simply be a matter of internal consistency. Anyway I've now made a list of the offenders so we can simply fix/delete them and continue. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/