Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757363AbZKRWJS (ORCPT ); Wed, 18 Nov 2009 17:09:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757121AbZKRWJS (ORCPT ); Wed, 18 Nov 2009 17:09:18 -0500 Received: from tundra.namei.org ([65.99.196.166]:37545 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756863AbZKRWJR (ORCPT ); Wed, 18 Nov 2009 17:09:17 -0500 Date: Thu, 19 Nov 2009 09:09:20 +1100 (EST) From: James Morris To: =?ISO-8859-15?Q?Am=E9rico_Wang?= cc: Alan Cox , linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov Subject: Re: [PATCH] selinux: Fix warnings In-Reply-To: <20091118160459.GA3287@hack> Message-ID: References: <20091118143951.4691.33970.stgit@localhost.localdomain> <20091118160459.GA3287@hack> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1825 Lines: 65 On Thu, 19 Nov 2009, Am?rico Wang wrote: > On Wed, Nov 18, 2009 at 02:39:51PM +0000, Alan Cox wrote: > >scripts/selinux/genheaders/genheaders.c:20: warning: no previous prototype > >for ?usage? > >scripts/selinux/genheaders/genheaders.c:26: warning: no previous prototype > >for ?stoupperx? > > > >Signed-off-by: Alan Cox > > Acked-by: WANG Cong > Thanks. Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next > >--- > > > > scripts/selinux/genheaders/genheaders.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > >diff --git a/scripts/selinux/genheaders/genheaders.c b/scripts/selinux/genheaders/genheaders.c > >index 3b16145..771b86f 100644 > >--- a/scripts/selinux/genheaders/genheaders.c > >+++ b/scripts/selinux/genheaders/genheaders.c > >@@ -17,13 +17,13 @@ struct security_class_mapping { > > > > const char *progname; > > > >-void usage(void) > >+static void usage(void) > > { > > printf("usage: %s flask.h av_permissions.h\n", progname); > > exit(1); > > } > > > >-char *stoupperx(const char *s) > >+static char *stoupperx(const char *s) > > { > > char *s2 = strdup(s); > > char *p; > > > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > >Please read the FAQ at http://www.tux.org/lkml/ > > -- > Live like a child, think like the god. > > -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/