MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       Arnaldo Carvalho de Melo <acme@redhat.com>,
       =?utf-8?q?Fr=C3=A9d=C3=A9ric=20Weisbecker?= <fweisbec@gmail.com>,
       Mike Galbraith <efault@gmx.de>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/4] perf symbols: Record the build_ids of kernel modules too
In-Reply-To: Arnaldo Carvalho de Melo's message of  Wednesday, 18 November 2009 20:20:52 -0200 <1258582853-8579-3-git-send-email-acme@infradead.org>
References: <1258582853-8579-1-git-send-email-acme@infradead.org>
	<1258582853-8579-2-git-send-email-acme@infradead.org>
	<1258582853-8579-3-git-send-email-acme@infradead.org>
Emacs: Lovecraft was an optimist.
Message-Id: <20091118222910.8F6F51983@magilla.sf.frob.com>
Date: Wed, 18 Nov 2009 14:29:10 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 756
Lines: 18

> +		snprintf(name, sizeof(name),
> +			 "/sys/module/%s/notes/.note.gnu.build-id", line);

The arch linker script for .ko's is free to fold notes into a single
section with a different name or suchlike, and maybe future ones will.  So
it's not pedantically kosher to assume the name of the section rather than
just looking at all the /sys/module/%s/notes/* files present until you find
NT_GNU_BUILD_ID.  (In practice there is probably only ever one file there
to look at, but you never know.)


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/