DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :x-enigmail-version:content-type;
        b=d0cIZgUEKmxrnYNZE6GD1/R1lQ+eBuYVwXkycakVQuVsJB9UwkKB8+t8+jqOdcYvwq
         aPtQhXo02EdVsxNK9pWZBjfs9HBmhc0RwF+wKZm1PHkdbgaG97Ia0X6ZrMTumvuDWLlb
         p+j7gZ9egjyx0yUvaOaPLvay1q1aHho9/bTDE=
Message-ID: <4B055479.8070101@gmail.com>
Date: Thu, 19 Nov 2009 09:21:45 -0500
From: Gregory Haskins <gregory.haskins@gmail.com>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: netdev@vger.kernel.org
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: NET: Questions about supporting older kernel's with kmods
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig87BC562EEA99524E08FF33E3"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2100
Lines: 53

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig87BC562EEA99524E08FF33E3
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi All,

So I was in the process of packaging up my venet driver so that it could
not only support the in-tree build (in -next), but also build as a KMP
for inclusion in existing distros that already shipped (like SLE, RHEL,
CentOS, etc).

The problem I ran into is that the ethtool and netdev_ops components of
the in-tree version do not necessarily align with the substrate
capabilities of older kernels.  What are the best-practices surrounding
this issue?

Q1) Is there any official CONFIG tags (e.g. HAVE_NETDEV_OPS) I can key
off of, or should I simply look at the kernel version?  If the latter,
any recommendation on what to use for the aforementioned features?  (I
can always try to git-annotate to figure it out, but I wonder if there
are best-practices already in place).

Q2) Is it considered "bad form" to include such compile-time directives
in the version of the code going upstream?  E.g. can my driver in -next
have "#ifdef CONFIG_HAVE_NETDEV_OPS" or other version/capability deps,
or do I need to patch these externally into the code destined for the
kmod, and leave the upstream code "pure"?

Thanks in advance,
-Greg


--------------enig87BC562EEA99524E08FF33E3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksFVHkACgkQP5K2CMvXmqEx6ACeNFgKO8X0f3TYAPcoenc11yRf
ungAn0JhYG23/1XVsJcMfn0gqbvBTPeB
=P0ZY
-----END PGP SIGNATURE-----

--------------enig87BC562EEA99524E08FF33E3--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/