Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757322AbZKSP66 (ORCPT ); Thu, 19 Nov 2009 10:58:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757177AbZKSP65 (ORCPT ); Thu, 19 Nov 2009 10:58:57 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:39034 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756813AbZKSP65 (ORCPT ); Thu, 19 Nov 2009 10:58:57 -0500 Subject: Re: virtio: Add memory statistics reporting to the balloon driver (V3) From: Adam Litke To: Avi Kivity Cc: Anthony Liguori , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org In-Reply-To: <4B0562A0.7040507@redhat.com> References: <1258643169.3464.3.camel@aglitke> <1258643945.3464.5.camel@aglitke> <4B0562A0.7040507@redhat.com> Content-Type: text/plain; charset="UTF-8" Organization: IBM Date: Thu, 19 Nov 2009 09:58:51 -0600 Message-ID: <1258646331.3464.18.camel@aglitke> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 28 On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote: > On 11/19/2009 05:19 PM, Adam Litke wrote: > > Rusty and Anthony, > > If I've addressed all outstanding issues, please consider this patch for > > inclusion. Thanks. > > > > +struct virtio_balloon_stat > > +{ > > + __le16 tag; > > + __le64 val; > > +}; > > + > > > > You're not doing endian conversion in the host? No. I was following by example. For the virtio_balloon, the existing code is careful so that the guest always writes data in little endian. -- Thanks, Adam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/