Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756335AbZKSVii (ORCPT ); Thu, 19 Nov 2009 16:38:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754745AbZKSVih (ORCPT ); Thu, 19 Nov 2009 16:38:37 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:59027 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754203AbZKSVig (ORCPT ); Thu, 19 Nov 2009 16:38:36 -0500 Message-ID: <4B05BADF.1010205@garzik.org> Date: Thu, 19 Nov 2009 16:38:39 -0500 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz CC: Alan Cox , Alan Cox , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 4/5] pata: Update experimental tags References: <20091117144450.15430.83450.stgit@localhost.localdomain> <20091118184125.623e063d@lxorguk.ukuu.org.uk> <200911182007.07405.bzolnier@gmail.com> <200911182056.16517.bzolnier@gmail.com> In-Reply-To: <200911182056.16517.bzolnier@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 31 On 11/18/2009 02:56 PM, Bartlomiej Zolnierkiewicz wrote: > On Wednesday 18 November 2009 20:07:07 Bartlomiej Zolnierkiewicz wrote: >> On Wednesday 18 November 2009 19:41:25 Alan Cox wrote: >>>> Maybe they are 'stable' but when it comes to features they are behind hpt366 >>>> (i.e. they lack PCI PM), which is also much cleaner than your drivers, easier >>>> to understand and much smaller.. >>> >>> 37x and 3xn lack PCI PM. Added to the TODO list. >>> >>> The smaller size is a bit questionable given its mostly comments, and >>> three drivers versus one. >> >> I wonder what you find 'questionable' in the numbers given.. > > BTW we can immediately reclaim 300 LOC by simply merging drivers back.. Merging drivers is a big pain for distributions and end users, even with the new module_alias facility. Absent stronger justification, libata remains with separate drivers, even if that means some code duplication. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/