Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbZKTKnr (ORCPT ); Fri, 20 Nov 2009 05:43:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752122AbZKTKnr (ORCPT ); Fri, 20 Nov 2009 05:43:47 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:40245 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724AbZKTKnq (ORCPT ); Fri, 20 Nov 2009 05:43:46 -0500 Date: Fri, 20 Nov 2009 05:43:35 -0500 From: Christoph Hellwig To: Ingo Molnar Cc: "Kok, Auke" , "Frank Ch. Eigler" , Arjan van de Ven , Jeff Garzik , "Wu, Fengguang" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Christoph Hellwig , Al Viro , Frederic Weisbecker Subject: Re: [PATCH] vfs: Add a trace point in the mark_inode_dirty function Message-ID: <20091120104335.GB29143@infradead.org> References: <20091025225342.007138f5@infradead.org> <20091111020108.GA11423@localhost> <20091110223456.01ef355f@infradead.org> <4AFA6AEF.5060306@garzik.org> <20091111081905.270a4e55@infradead.org> <4AFB4AC7.1090405@intel.com> <20091112072217.GA31719@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091112072217.GA31719@elte.hu> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 22 Guys, I think both the inode number and name do have a use case. For file system developers observing the filesystem the inode number is very useful, and if you look at the ext4 tracing already in tree or the xfs tracing going in in the next window they use the inode number all over. Which btw brings up another good argument - to make the tracing really useful we need to have conventions. While the inode number seems to be a realtively easy one printing the device is more difficult. XFS just prints the raw major/minor to stay simple, ext4 has a complicated ad-hoc cache of device names, and this one just prints the superblock id string. Of course for a user the name is a lot more meaninful, but also relatively expensive to generate. Then again I'm not even sure how the last pathname component only here is all that useful - it can't be used to easily find the file. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/