Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753804AbZKTOnj (ORCPT ); Fri, 20 Nov 2009 09:43:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753592AbZKTOni (ORCPT ); Fri, 20 Nov 2009 09:43:38 -0500 Received: from casper.infradead.org ([85.118.1.10]:34219 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbZKTOnh (ORCPT ); Fri, 20 Nov 2009 09:43:37 -0500 Date: Fri, 20 Nov 2009 06:45:11 -0800 From: Arjan van de Ven To: Christoph Hellwig Cc: Ingo Molnar , "Kok, Auke" , "Frank Ch. Eigler" , Jeff Garzik , "Wu, Fengguang" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Christoph Hellwig , Al Viro , Frederic Weisbecker Subject: Re: [PATCH] vfs: Add a trace point in the mark_inode_dirty function Message-ID: <20091120064511.268cc8fd@infradead.org> In-Reply-To: <20091120104335.GB29143@infradead.org> References: <20091025225342.007138f5@infradead.org> <20091111020108.GA11423@localhost> <20091110223456.01ef355f@infradead.org> <4AFA6AEF.5060306@garzik.org> <20091111081905.270a4e55@infradead.org> <4AFB4AC7.1090405@intel.com> <20091112072217.GA31719@elte.hu> <20091120104335.GB29143@infradead.org> Organization: Intel X-Mailer: Claws Mail 3.7.3 (GTK+ 2.16.6; i586-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 36 On Fri, 20 Nov 2009 05:43:35 -0500 Christoph Hellwig wrote: > > Which btw brings up another good argument - to make the tracing really > useful we need to have conventions. While the inode number seems to > be a realtively easy one printing the device is more difficult. XFS > just prints the raw major/minor to stay simple, ext4 has a > complicated ad-hoc cache of device names, and this one just prints > the superblock id string. I was just trying to stay compatible with blockdump, and it even makes sense ;) > > Of course for a user the name is a lot more meaninful, but also > relatively expensive to generate. Then again I'm not even sure how > the last pathname component only here is all that useful - it can't > be used to easily find the file. in my case it's not about finding the file, but finding the place in the application that is doing the writing. The last pathname component is more than enough for this.... > -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/