Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbZKUMFr (ORCPT ); Sat, 21 Nov 2009 07:05:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753766AbZKUMFq (ORCPT ); Sat, 21 Nov 2009 07:05:46 -0500 Received: from mail-px0-f204.google.com ([209.85.216.204]:64608 "EHLO mail-px0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753505AbZKUMFp (ORCPT ); Sat, 21 Nov 2009 07:05:45 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=dW0AXlBc+xQzDjpG0ijhAXVZ401cEvz5OM/GT2F6W8pQYRWjB+cB9+2E/EVLMeF3m1 yFVEmiMEY/dXt7BRaZL4FyL0YGVxe8dPArlhfLa4Q1mD1001rCKTyLy4ALxRZk5ww9Bl bTtlHrIjbUewn0agPBVyCOYJFu6//lsRDbvts= MIME-Version: 1.0 In-Reply-To: <1258798699-631-1-git-send-email-petkovbb@gmail.com> References: <1258798699-631-1-git-send-email-petkovbb@gmail.com> Date: Sat, 21 Nov 2009 18:05:52 +0600 Message-ID: Subject: Re: [PATCH] x86, cpu: mv display_cacheinfo -> cpu_detect_cache_sizes From: Rakib Mullick To: Borislav Petkov Cc: mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4375 Lines: 120 On 11/21/09, Borislav Petkov wrote: > display_cacheinfo() doesn't display anything anymore and it is solely > used to detect CPU cache sizes for /proc/cpuinfo. Rename it accordingly. > Hi Borislav, If it is only displays cache sizes for /proc/cpuinfo, then we need to check #ifdef CONFIG_PROC_FS , isn't it? > Signed-off-by: Borislav Petkov > --- > arch/x86/kernel/cpu/amd.c | 2 +- > arch/x86/kernel/cpu/centaur.c | 2 +- > arch/x86/kernel/cpu/common.c | 4 ++-- > arch/x86/kernel/cpu/cpu.h | 2 +- > arch/x86/kernel/cpu/cyrix.c | 2 +- > arch/x86/kernel/cpu/transmeta.c | 2 +- > 6 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index c910a71..7128b37 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -535,7 +535,7 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c) > } > } > > - display_cacheinfo(c); > + cpu_detect_cache_sizes(c); > > /* Multi core CPU? */ > if (c->extended_cpuid_level >= 0x80000008) { > diff --git a/arch/x86/kernel/cpu/centaur.c b/arch/x86/kernel/cpu/centaur.c > index c95e831..e58d978 100644 > --- a/arch/x86/kernel/cpu/centaur.c > +++ b/arch/x86/kernel/cpu/centaur.c > @@ -294,7 +294,7 @@ static void __cpuinit init_c3(struct cpuinfo_x86 *c) > set_cpu_cap(c, X86_FEATURE_REP_GOOD); > } > > - display_cacheinfo(c); > + cpu_detect_cache_sizes(c); > } > > enum { > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 61242a5..9bf845d 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -61,7 +61,7 @@ void __init setup_cpu_local_masks(void) > static void __cpuinit default_init(struct cpuinfo_x86 *c) > { > #ifdef CONFIG_X86_64 > - display_cacheinfo(c); > + cpu_detect_cache_sizes(c); > #else > /* Not much we can do here... */ > /* Check if at least it has cpuid */ > @@ -383,7 +383,7 @@ static void __cpuinit get_model_name(struct cpuinfo_x86 *c) > } > } > > -void __cpuinit display_cacheinfo(struct cpuinfo_x86 *c) > +void __cpuinit cpu_detect_cache_sizes(struct cpuinfo_x86 *c) > { > unsigned int n, dummy, ebx, ecx, edx, l2size; > > diff --git a/arch/x86/kernel/cpu/cpu.h b/arch/x86/kernel/cpu/cpu.h > index 6de9a90..3624e8a 100644 > --- a/arch/x86/kernel/cpu/cpu.h > +++ b/arch/x86/kernel/cpu/cpu.h > @@ -32,6 +32,6 @@ struct cpu_dev { > extern const struct cpu_dev *const __x86_cpu_dev_start[], > *const __x86_cpu_dev_end[]; > > -extern void display_cacheinfo(struct cpuinfo_x86 *c); > +extern void cpu_detect_cache_sizes(struct cpuinfo_x86 *c); > > #endif > diff --git a/arch/x86/kernel/cpu/cyrix.c b/arch/x86/kernel/cpu/cyrix.c > index 19807b8..4fbd384 100644 > --- a/arch/x86/kernel/cpu/cyrix.c > +++ b/arch/x86/kernel/cpu/cyrix.c > @@ -373,7 +373,7 @@ static void __cpuinit init_nsc(struct cpuinfo_x86 *c) > /* Handle the GX (Formally known as the GX2) */ > > if (c->x86 == 5 && c->x86_model == 5) > - display_cacheinfo(c); > + cpu_detect_cache_sizes(c); > else > init_cyrix(c); > } > diff --git a/arch/x86/kernel/cpu/transmeta.c b/arch/x86/kernel/cpu/transmeta.c > index bb62b3e..2800074 100644 > --- a/arch/x86/kernel/cpu/transmeta.c > +++ b/arch/x86/kernel/cpu/transmeta.c > @@ -26,7 +26,7 @@ static void __cpuinit init_transmeta(struct cpuinfo_x86 *c) > > early_init_transmeta(c); > > - display_cacheinfo(c); > + cpu_detect_cache_sizes(c); > > /* Print CMS and CPU revision */ > max = cpuid_eax(0x80860000); > -- > 1.6.5 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/