DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=bAq63kneaZTizRQDdR+/wL3/ONktw46H/ub5JtkXPpDrvHhQ+D5AMkR8R8VLdbCLw1
         WhmlxdOfpvLD7kPHboUr34GhLXRHag4wgPKi0Ph6FaVV8Qxk8mx1UbNpchcGNyEgmFTR
         ueHPuCMnJzMU69ZaAkMyk2jdkHKANRuMvubj4=
MIME-Version: 1.0
In-Reply-To: <m18wdypvjd.fsf@fess.ebiederm.org>
References: <86802c440911220226g21cc42bbmdc3ebe21d0f61943@mail.gmail.com>
	 <m18wdypvjd.fsf@fess.ebiederm.org>
Date: Sun, 22 Nov 2009 17:18:09 -0800
Message-ID: <86802c440911221718l541c0dq599f6a401fd03157@mail.gmail.com>
Subject: Re: [PATCH] x86: crash kernel reserve with reserve_early
From: Yinghai Lu <yhlu.kernel@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
       Thomas Gleixner <tglx@linutronix.de>, Vivek Goyal <vgoyal@redhat.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       kexec@lists.infradead.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 725
Lines: 22

On Sun, Nov 22, 2009 at 4:56 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
> Yinghai Lu <yhlu.kernel@gmail.com> writes:
>
>> [PATCH] x86: crash kernel reserve with reserve_early
>>
>> use find_e820_area/reserve_early instead.
>> will get next good one automatically with alignment
>
> Semantically this is broken, as you are now ignoring a passed in
> base address if one is supplied. ?What problem are you trying to fix?

avoid to use bootmem.

also simpify the code.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/