Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754419AbZKWIVj (ORCPT ); Mon, 23 Nov 2009 03:21:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752884AbZKWIVi (ORCPT ); Mon, 23 Nov 2009 03:21:38 -0500 Received: from elettra.colt-to.towertech.it ([213.215.222.70]:57547 "EHLO elettra.colt-to.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752588AbZKWIVh (ORCPT ); Mon, 23 Nov 2009 03:21:37 -0500 Date: Mon, 23 Nov 2009 09:21:41 +0100 From: Alessandro Zummo To: Wan ZongShun Cc: rtc-linux@googlegroups.com, Paul Gortmaker , linux-arm-kernel , linux-kernel Subject: Re: [rtc-linux] [PATCH] ARM: NUC900: add rtc controller driver support for NUC900 Message-ID: <20091123092141.519d0ec1@linux.lan.towertech.it> In-Reply-To: <4B0A2D31.5020307@gmail.com> References: <4B097FA0.8040308@gmail.com> <20091122214107.1a0c4e72@linux.lan.towertech.it> <4B0A2D31.5020307@gmail.com> Organization: Tower Technologies X-Mailer: Sylpheed X-This-Is-A-Real-Message: Yes Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 25 On Mon, 23 Nov 2009 14:35:29 +0800 Wan ZongShun wrote: > Thanks a lot for your advice, and I have fixed my patch. > But, I have a question ,which is that why do not implement ops->ioctl() > unless absolutely necessary? and I see many other rtc driver have implemented it. That's because the RTC framework will provide one for you if you define the irq functions in your rtc_ops. check *_irq_enable, irq_set_state, irq_set_freq. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/