Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756858AbZKWKZ2 (ORCPT ); Mon, 23 Nov 2009 05:25:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756145AbZKWKZ1 (ORCPT ); Mon, 23 Nov 2009 05:25:27 -0500 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:51036 "EHLO e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752588AbZKWKZ0 (ORCPT ); Mon, 23 Nov 2009 05:25:26 -0500 Date: Mon, 23 Nov 2009 15:55:28 +0530 From: Balbir Singh To: Stanislaw Gruszka Cc: Hidetoshi Seto , Peter Zijlstra , Spencer Candland , Am?rico Wang , linux-kernel@vger.kernel.org, Ingo Molnar , Oleg Nesterov Subject: Re: [PATCH] fix granularity of task_u/stime(), v2 Message-ID: <20091123102528.GT31961@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <4AFB9029.9000208@jp.fujitsu.com> <20091112144919.GA6218@dhcp-lab-161.englab.brq.redhat.com> <1258038038.4039.467.camel@laptop> <20091112154050.GC6218@dhcp-lab-161.englab.brq.redhat.com> <4B01A8DB.6090002@bluehost.com> <20091117130851.GA3842@dhcp-lab-161.englab.brq.redhat.com> <1258464288.7816.305.camel@laptop> <20091119181744.GA3743@dhcp-lab-161.englab.brq.redhat.com> <4B05F835.10401@jp.fujitsu.com> <20091123100925.GB25978@dhcp-lab-161.englab.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20091123100925.GB25978@dhcp-lab-161.englab.brq.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 19 * Stanislaw Gruszka [2009-11-23 11:09:26]: [snip] > + > + utime = task_utime(tsk); > + stime = task_stime(tsk); > + if (tsk->utime > utime || tsk->stime > stime) { > + utime = tsk->utime; > + stime = tsk->stime; > + } Won't this condition be problematic, since it can reset stime when tsk->utime > utime for example? -- Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/