Message-ID: <4B0A8710.9060104@redhat.com>
Date: Mon, 23 Nov 2009 10:58:56 -0200
From: Mauro Carvalho Chehab <mchehab@redhat.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Jarod Wilson <jarod@redhat.com>
CC: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
       linux-media@vger.kernel.org, Janne Grunau <j@jannau.net>,
       Christoph Bartelmus <lirc@bartelmus.de>
Subject: Re: [PATCH 3/3 v2] lirc driver for SoundGraph iMON IR receivers and
 displays
References: <200910200956.33391.jarod@redhat.com> <200910201000.57536.jarod@redhat.com>
In-Reply-To: <200910201000.57536.jarod@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1616
Lines: 47

Jarod Wilson wrote:
> lirc driver for SoundGraph iMON IR receivers and displays
> 
> Successfully tested with multiple devices with and without displays.
> 


> +static struct usb_device_id imon_usb_id_table[] = {
> +	/* TriGem iMON (IR only) -- TG_iMON.inf */
> +	{ USB_DEVICE(0x0aa8, 0x8001) },
...

Another set of USB vendor ID's... this time, vendors weren't described. The
same comment I did on patch 2/3 applies here... IMO, we should really try
to create a global list of vendors/devices on kernel. Of course this is not
a non-go issue, as it is already present on several other USB drivers.

> +
> +	/*
> +	 * Translate received data to pulse and space lengths.
> +	 * Received data is active low, i.e. pulses are 0 and
> +	 * spaces are 1.
> +	 *
> +	 * My original algorithm was essentially similar to
> +	 * Changwoo Ryu's with the exception that he switched
> +	 * the incoming bits to active high and also fed an
> +	 * initial space to LIRC at the start of a new sequence
> +	 * if the previous bit was a pulse.
> +	 *
> +	 * I've decided to adopt his algorithm.
> +	 */
> +

Before digging into all code details, am I wrong or this device has the
pulse/space decoding inside the chip?

In this case, we shouldn't really be converting their IR keystroke events into
a pseudo set of pulse/space marks, but use the standard events interface.

Cheers,
Mauro.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/