Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754897AbZKWORu (ORCPT ); Mon, 23 Nov 2009 09:17:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753775AbZKWORt (ORCPT ); Mon, 23 Nov 2009 09:17:49 -0500 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:36086 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753705AbZKWORt (ORCPT ); Mon, 23 Nov 2009 09:17:49 -0500 Date: Mon, 23 Nov 2009 15:17:54 +0100 From: Jens Axboe To: Pavel Machek Cc: Matthew Garrett , Kay Sievers , David Zeuthen , linux-kernel@vger.kernel.org, linux-hotplug@vger.kernel.org Subject: Re: [PATCH] [RFC] Add support for uevents on block device idle changes Message-ID: <20091123141754.GE8742@kernel.dk> References: <1258474180.16176.62.camel@localhost.localdomain> <20091117185742.GA19829@srcf.ucam.org> <20091118194053.GB12944@srcf.ucam.org> <20091118195342.GA13627@srcf.ucam.org> <20091118200712.GA14026@srcf.ucam.org> <20091122233749.GA9699@ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091122233749.GA9699@ucw.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 32 On Mon, Nov 23 2009, Pavel Machek wrote: > On Wed 2009-11-18 20:07:12, Matthew Garrett wrote: > > On Wed, Nov 18, 2009 at 09:03:21PM +0100, Kay Sievers wrote: > > > > > Sure, but what's wrong with reading that file every 50 seconds? Almost > > > all boxes poll for media changes of optical drives and usb card > > > readers anyway, so it's not that we are not doing stuff like this > > > already. > > > > We poll for media because there's no event-based way of avoiding it - in > > this case there is. > > ...when you add overhead to every disk operation. I'd say that polling > once in 50 seconds is preferable to that. I have to agree, doing a mod_timer() on every single IO is going to suck big time. I went to great lengths to avoid doing that even for timeout detection. So that's pretty much a non-starter to begin with. Additionally, as Bart also wrote, you are not doing this in the right place. You want to do this post-merge, not for each incoming IO. Have you looked at laptop mode? Looks like you are essentially re-inventing that, but in a bad way. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/