Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752928AbZKWQw5 (ORCPT ); Mon, 23 Nov 2009 11:52:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752122AbZKWQw5 (ORCPT ); Mon, 23 Nov 2009 11:52:57 -0500 Received: from mail-yx0-f187.google.com ([209.85.210.187]:54413 "EHLO mail-yx0-f187.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbZKWQw4 (ORCPT ); Mon, 23 Nov 2009 11:52:56 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=h7zd2yazXeYMvA5m9Vu9bDNrgA0ib15hPiBVhh5dejKC29CP05N1L6PVnThK76P27r bKwyt8ek8/4PwLYiqvZa2iEIkh0B0KlEnA9Ug55fBJdFud0JnlpOQ3J1yp0cfbhFv8aj lfca6rm6R/jlTi0o9E7zUh3zcqpnY8gxFQvTo= MIME-Version: 1.0 In-Reply-To: <829197380911230720k233c3c86t659180d1413aa0dd@mail.gmail.com> References: <200910200956.33391.jarod@redhat.com> <200910200958.50574.jarod@redhat.com> <4B0A765F.7010204@redhat.com> <4B0A81BF.4090203@redhat.com> <829197380911230720k233c3c86t659180d1413aa0dd@mail.gmail.com> Date: Mon, 23 Nov 2009 16:53:00 +0000 X-Google-Sender-Auth: 0349d4cec0ea884e Message-ID: Subject: Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure From: James Mastros To: Devin Heitmueller Cc: Krzysztof Halasa , Mauro Carvalho Chehab , Jarod Wilson , Dmitry Torokhov , linux-kernel@vger.kernel.org, Mario Limonciello , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Janne Grunau , Christoph Bartelmus Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2871 Lines: 50 2009/11/23 Devin Heitmueller : > Just bear in mind that with the current in-kernel code, users do *not > * have to manually select the RC code to use if they are using the > default remote that shipped with the product. This could still happen, if LIRC checks the identifiers of the reciving device, and has a database that tells it mappings between those devices and the remote controls that shipped with them. However, it occours to me that the IR circumstances map pretty well to what happens with ps/2 and serial devices now: 1: There are a variety of drivers for serio computer-side hardware, each of which speaks the serio interface to the next-higher level. These corrospond to the drivers for IR recievers. 2: There's a raw serio interface, for those wishing to do strange things. 3: There's also a variety of things that take data, using the kernel serio API, and decode it into input events -- the ps2 keyboard driver, the basic mouse driver, the advanced mice drivers. This is where the interface falls down a little bit -- the ps2 keyboard driver is the closest analogue to what I'm suggesting. The ps2 keyboard driver creates scancode events, which map nicely to what the keyboard is sending -- these are, for ex, rc5 codes. It will also produce key-up/key-down events, if it has a keymap loaded. (This is the difference with a ps2 keyboard -- a ps2 keyboard gets a map assigned to it at boottime, so it works out-of-box. This isn't really possible with an IR remote -- though perhaps rc5 is standarized enough, I don't think other protocols neccessarly are.) Userspace would have to load a keymap; those don't really belong in kernel code. Of course, userspace could look at the device identifiers to pick a reasonable default keymap if it's not configured to load another, solving the out-of-box experince. Why is this such a contentious point? I can understand wanting to keep uncommon decoding algos out of the kernel, and keymaps, but at the same time, they are currently there, in multiple drivers, and while colesing them into a single place each makes sense, I'm not convinced that moving them out completely makes all that much sense. Having an explicit layer between the raw pulse/space layer and the decoders means that usespace can hook in there, and create scancode events, if it wishes to, but for the majority of remotes that use just a couple of encoding schemes, the code can stay in the kernel. Of course, devices that do the decoding in hardware would not implement the raw interface, but simply create the scancode/keycode events. -=- James Mastros -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/