Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755007AbZKWS2A (ORCPT ); Mon, 23 Nov 2009 13:28:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754731AbZKWS2A (ORCPT ); Mon, 23 Nov 2009 13:28:00 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58673 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbZKWS17 (ORCPT ); Mon, 23 Nov 2009 13:27:59 -0500 Date: Mon, 23 Nov 2009 10:28:17 -0800 (PST) Message-Id: <20091123.102817.157628485.davem@davemloft.net> To: hartleys@visionengravers.com Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: drivers/ide/au1xxx-ide.c: use resource_size() From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 24 From: "H Hartley Sweeten" Date: Mon, 23 Nov 2009 13:15:32 -0500 > Use resource_size() for {request/release}_mem_region and ioremap. > > Signed-off-by: H Hartley Sweeten Applied to ide-next-2.6, thanks. > > - ahwif->regbase = (u32)ioremap(res->start, res->end - res->start + 1); > + ahwif->regbase = (u32)ioremap(res->start, resource_size(res)); > if (ahwif->regbase == 0) { > ret = -ENOMEM; > goto out; That needs some fixing. ioremap()'s return value is an "__iomem" pointer, not an integer. ->regbase's type should be changed to something like "void __iomem *" etc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/