Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753381AbZKWShB (ORCPT ); Mon, 23 Nov 2009 13:37:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754200AbZKWShA (ORCPT ); Mon, 23 Nov 2009 13:37:00 -0500 Received: from exprod6og115.obsmtp.com ([64.18.1.35]:58046 "EHLO exprod6og115.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbZKWSg7 convert rfc822-to-8bit (ORCPT ); Mon, 23 Nov 2009 13:36:59 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: RE: drivers/ide/au1xxx-ide.c: use resource_size() Date: Mon, 23 Nov 2009 13:37:05 -0500 Message-ID: In-Reply-To: <20091123.102817.157628485.davem@davemloft.net> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: drivers/ide/au1xxx-ide.c: use resource_size() Thread-Index: AcpsarQeRT0PCtLFS7WeUOEZJOdKvgAAO/wg References: <20091123.102817.157628485.davem@davemloft.net> From: "H Hartley Sweeten" To: "David Miller" Cc: , X-OriginalArrivalTime: 23 Nov 2009 18:37:04.0802 (UTC) FILETIME=[F436E820:01CA6C6B] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 33 On Monday, November 23, 2009 11:28 AM, David Miller wrote: > From: "H Hartley Sweeten" > Date: Mon, 23 Nov 2009 13:15:32 -0500 > >> Use resource_size() for {request/release}_mem_region and ioremap. >> >> Signed-off-by: H Hartley Sweeten > > Applied to ide-next-2.6, thanks. > >> >> - ahwif->regbase = (u32)ioremap(res->start, res->end - res->start + 1); >> + ahwif->regbase = (u32)ioremap(res->start, resource_size(res)); >> if (ahwif->regbase == 0) { >> ret = -ENOMEM; >> goto out; > > That needs some fixing. ioremap()'s return value is an > "__iomem" pointer, not an integer. ->regbase's type should be > changed to something like "void __iomem *" etc. Agree. But that was already in the driver. I don't have to hardware to test this so I didn't want to dig to deeply into fixing that. Thanks, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/