Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755636AbZKWSzl (ORCPT ); Mon, 23 Nov 2009 13:55:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755564AbZKWSzk (ORCPT ); Mon, 23 Nov 2009 13:55:40 -0500 Received: from hera.kernel.org ([140.211.167.34]:56017 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382AbZKWSzi (ORCPT ); Mon, 23 Nov 2009 13:55:38 -0500 Date: Mon, 23 Nov 2009 18:54:36 GMT From: tip-bot for Jan Blunck Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com, jamie@shareable.org, peterz@infradead.org, alan@lxorguk.ukuu.org.uk, jblunck@suse.de, hch@infradead.org, arnd@arndb.de, fweisbec@gmail.com, tglx@linutronix.de, mingo@elte.hu Reply-To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, jamie@shareable.org, peterz@infradead.org, jblunck@suse.de, alan@lxorguk.ukuu.org.uk, hch@infradead.org, arnd@arndb.de, fweisbec@gmail.com, tglx@linutronix.de, mingo@elte.hu In-Reply-To: <1258735245-25826-8-git-send-email-jblunck@suse.de> References: <1258735245-25826-8-git-send-email-jblunck@suse.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched_feat_write(): Update ppos instead of file->f_pos Message-ID: Git-Commit-ID: 429947248f814e90f416ab4f68a871ab628000c3 X-Mailer: tip-git-log-daemon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1522 Lines: 45 Commit-ID: 429947248f814e90f416ab4f68a871ab628000c3 Gitweb: http://git.kernel.org/tip/429947248f814e90f416ab4f68a871ab628000c3 Author: Jan Blunck AuthorDate: Fri, 20 Nov 2009 17:40:37 +0100 Committer: Ingo Molnar CommitDate: Mon, 23 Nov 2009 19:38:03 +0100 sched_feat_write(): Update ppos instead of file->f_pos sched_feat_write() should update ppos instead of file->f_pos. (This reduces some BKL dependencies of this code.) Signed-off-by: Jan Blunck Cc: jkacur@redhat.com Cc: Arnd Bergmann Cc: Frederic Weisbecker Cc: Jamie Lokier Cc: Peter Zijlstra Cc: Christoph Hellwig Cc: Alan Cox LKML-Reference: <1258735245-25826-8-git-send-email-jblunck@suse.de> Signed-off-by: Ingo Molnar --- kernel/sched.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/sched.c b/kernel/sched.c index ab9a034..93474a7 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -771,7 +771,7 @@ sched_feat_write(struct file *filp, const char __user *ubuf, if (!sched_feat_names[i]) return -EINVAL; - filp->f_pos += cnt; + *ppos += cnt; return cnt; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/