Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756850AbZKWUUW (ORCPT ); Mon, 23 Nov 2009 15:20:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756113AbZKWUUV (ORCPT ); Mon, 23 Nov 2009 15:20:21 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:50524 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755589AbZKWUUU (ORCPT ); Mon, 23 Nov 2009 15:20:20 -0500 Date: Mon, 23 Nov 2009 12:20:38 -0800 (PST) Message-Id: <20091123.122038.64001211.davem@davemloft.net> To: hartleys@visionengravers.com Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: drivers/ide/au1xxx-ide.c: use resource_size() From: David Miller In-Reply-To: References: <20091123.103810.44071453.davem@davemloft.net> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 27 From: "H Hartley Sweeten" Date: Mon, 23 Nov 2009 15:01:02 -0500 > On Monday, November 23, 2009 11:38 AM, David Miller wrote: >>> >>> - ahwif->regbase = (u32)ioremap(res->start, res->end - res->start + 1); >>> + ahwif->regbase = (u32)ioremap(res->start, resource_size(res)); >>> if (ahwif->regbase == 0) { >>> ret = -ENOMEM; >>> goto out; >> >> That needs some fixing. ioremap()'s return value is an >> "__iomem" pointer, not an integer. ->regbase's type should be >> changed to something like "void __iomem *" etc. > > FWIW, following is an updated patch that fixes the "__iomem" pointer. Please, I've already applied your resource_size() patch, and you should submit a seperate patch relative to that in order to address the ioremap() pointer issues. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/