Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757264AbZKWVk2 (ORCPT ); Mon, 23 Nov 2009 16:40:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757024AbZKWVk2 (ORCPT ); Mon, 23 Nov 2009 16:40:28 -0500 Received: from smtprelay02.ispgateway.de ([80.67.31.36]:40934 "EHLO smtprelay02.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756001AbZKWVk1 (ORCPT ); Mon, 23 Nov 2009 16:40:27 -0500 X-Greylist: delayed 364 seconds by postgrey-1.27 at vger.kernel.org; Mon, 23 Nov 2009 16:40:27 EST From: Ingo Oeser To: "H Hartley Sweeten" Subject: Re: drivers/dma/mv_xor.c: use resource_size() Date: Mon, 23 Nov 2009 22:34:41 +0100 User-Agent: KMail/1.12.2 (Linux/2.6.31-15-generic; KDE/4.3.2; x86_64; ; ) Cc: linux-kernel@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200911232234.41411.ioe-lkml@rameria.de> X-Df-Sender: 849595 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 593 Lines: 22 Hi, On Monday 23 November 2009, H Hartley Sweeten wrote: > Use resource_size() for devm_ioremap. This pattern foo = do_with_res(res->start, resource_size(res)) seem to happen quite often. What about creating inline functions like foo = do_with_full_res(res) ? That would save some code and make it obviously correct. Best Regards Ingo Oeser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/