Message-ID: <4B0B4362.1020809@csr.com>
Date: Tue, 24 Nov 2009 02:22:26 +0000
From: David Vrabel <david.vrabel@csr.com>
User-Agent: Thunderbird 2.0.0.23 (Windows/20090812)
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: Roel Kluin <roel.kluin@gmail.com>, linux-usb@vger.kernel.org,
       LKML <linux-kernel@vger.kernel.org>
References: <4B0836A2.1000805@gmail.com> <20091123163745.60c719c7.akpm@linux-foundation.org>
In-Reply-To: <20091123163745.60c719c7.akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wusb: Use sizeof struct rather than pointer
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 822
Lines: 21

Andrew Morton wrote:
> 
> But I wonder if the code will still work.  Because we then go on to do
> 
>         secd_size = le16_to_cpu(secd->wTotalLength);
>         secd = krealloc(secd, secd_size, GFP_KERNEL);
> 
> which implies (to me) that the thing we read from the device might
> indeed have been smaller than we expected, in which case the
> newly-fixed check will cause a failure.

We first read the security descriptor which tells use the total length 
of the security descriptor plus all the following encryption type 
descriptors.  Your revised patch is fine.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/