Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932704AbZKXKkW (ORCPT ); Tue, 24 Nov 2009 05:40:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932687AbZKXKkV (ORCPT ); Tue, 24 Nov 2009 05:40:21 -0500 Received: from stinky.trash.net ([213.144.137.162]:64842 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932682AbZKXKkU (ORCPT ); Tue, 24 Nov 2009 05:40:20 -0500 Message-ID: <4B0BB818.6090509@trash.net> Date: Tue, 24 Nov 2009 11:40:24 +0100 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Arnd Bergmann CC: virtualization@lists.linux-foundation.org, Herbert Xu , Eric Dumazet , Anna Fischer , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Mark Smith , Gerhard Stenzel , "Eric W. Biederman" , Jens Osterkamp , Patrick Mullaney , Stephen Hemminger , Edge Virtual Bridging , David Miller Subject: Re: [PATCH 1/4] veth: move loopback logic to common location References: <1259024166-28158-1-git-send-email-arnd@arndb.de> <200911241002.20904.arnd@arndb.de> <4B0BB2A7.5040707@trash.net> <200911241034.43961.arnd@arndb.de> In-Reply-To: <200911241034.43961.arnd@arndb.de> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2178 Lines: 46 Arnd Bergmann wrote: > On Tuesday 24 November 2009 10:17:11 Patrick McHardy wrote: >> Arnd Bergmann wrote: >>> On Tuesday 24 November 2009 09:51:19 Patrick McHardy wrote: >>>>> + skb_dst_drop(skb); >>>>> + skb->tstamp.tv64 = 0; >>>>> + skb->pkt_type = PACKET_HOST; >>>>> + skb->protocol = eth_type_trans(skb, dev); >>>>> + skb->mark = 0; >>>> skb->mark clearing should stay private to veth since its usually >>>> supposed to stay intact. The only exception is packets crossing >>>> namespaces, where they should appear like a freshly received skbs. >>> But isn't that what we want in macvlan as well when we're >>> forwarding from one downstream interface to another? >> In the TX direction you can use the mark for TC classification >> on the underlying device. > > I don't use dev_forward_skb for the case where the data is sent > to the underlying device, so the TC classification should stay > intact. Right, I see. This looks fine. >>> I did all my testing with macvlan interfaces in separate namespaces >>> communicating with each other, so I'd assume that we should always >>> clear skb->mark and skb->dst in this function. >> Good point, in that case we probably should clear it as well. But >> in the non-namespace case the TC classification currently works and >> this is consistent with any other virtual device driver, so it >> should continue to work. > > Do you think we should be able to use TC to direct traffic between > macvlans on the same underlying device in bridge mode? It does sound > useful, but I'm not sure how to implement that or if you'd expect > it to work with the current code. If we support that, it should probably > also work with namespaces, by consuming the mark in the macvlan > and veth drivers. I don't think its necessary, we bypass outgoing queuing anyways. But if you'd want to add it, just keeping the skb->mark clearing in veth should work from what I can tell. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/