Date: Tue, 24 Nov 2009 12:20:58 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Tim Blechmann <tim@klingt.org>, Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] slab.c: remove branch hint
Message-ID: <20091124112058.GA23765@elte.hu>
References: <cover.1259059549.git.tim@klingt.org>
 <4B0BBBA8.2090604@klingt.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B0BBBA8.2090604@klingt.org>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1023
Lines: 38


(Pekka Cc:-ed)

* Tim Blechmann <tim@klingt.org> wrote:

> branch profiling on my nehalem machine showed 99% incorrect branch hints:
> 
>    28459  7678524  99 __cache_alloc_node             slab.c
>   3551
> 
> Signed-off-by: Tim Blechmann <tim@klingt.org>
> ---
>  mm/slab.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index f70b326..4125fcd 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3548,7 +3548,7 @@ __cache_alloc_node(struct kmem_cache *cachep,
> gfp_t flags, int nodeid,
>  	slab_irq_save(save_flags, this_cpu);
>   	this_node = cpu_to_node(this_cpu);
> -	if (unlikely(nodeid == -1))
> +	if (nodeid == -1)
>  		nodeid = this_node;
>   	if (unlikely(!cachep->nodelists[nodeid])) {
> -- 
> 1.6.4.2
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/