Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932869AbZKXUUP (ORCPT ); Tue, 24 Nov 2009 15:20:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932541AbZKXUUO (ORCPT ); Tue, 24 Nov 2009 15:20:14 -0500 Received: from mail-ew0-f215.google.com ([209.85.219.215]:39501 "EHLO mail-ew0-f215.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932504AbZKXUUM (ORCPT ); Tue, 24 Nov 2009 15:20:12 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=hWByb6ZvzhOX9lVtlwUDiQ/W+xh+1o3p0t5kwa66TJNJWuPzESxqlnNPMEjdasAr/3 GMgSQ/NlL0K2UiUhLHULzzscmnIZrvZ4by9se/nK2OgQh7JeGsCHQGJXmwrZ5aSjBVsJ fveUjYkc0NuQQ9QlioyDx8zLoSajdALSbqqhg= Date: Tue, 24 Nov 2009 21:20:00 +0100 From: Frederic Weisbecker To: "Frank Ch. Eigler" Cc: Masami Hiramatsu , Ingo Molnar , Ananth N Mavinakayanahalli , lkml , systemtap , DLE , Jim Keniston , Srikar Dronamraju , Christoph Hellwig , Steven Rostedt , "H. Peter Anvin" , Anders Kaseorg , Tim Abbott , Andi Kleen , Jason Baron , Mathieu Desnoyers Subject: Re: [PATCH -tip v5 06/10] kprobes/x86: Cleanup save/restore registers Message-ID: <20091124201957.GD5071@nowhere> References: <20091123232115.22071.71558.stgit@dhcp-100-2-132.bos.redhat.com> <20091123232204.22071.60562.stgit@dhcp-100-2-132.bos.redhat.com> <20091124025115.GB6752@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 747 Lines: 23 On Tue, Nov 24, 2009 at 10:40:24AM -0500, Frank Ch. Eigler wrote: > Frederic Weisbecker writes: > > > [...] > >> +#define SAVE_REGS_STRING \ > >> +#define RESTORE_REGS_STRING \ > > > > BTW, do you really need to push/pop every registers > > before/after calling a probe handler? > > It's part of the definition of a kprobe, that a populated > pt_regs* value is passed. Clients can rely on that in order > to access registers etc. > > - FChE Yeah I made a confusion. Sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/