Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932772AbZKXUfh (ORCPT ); Tue, 24 Nov 2009 15:35:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932375AbZKXUfg (ORCPT ); Tue, 24 Nov 2009 15:35:36 -0500 Received: from one.firstfloor.org ([213.235.205.2]:51737 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757572AbZKXUfg (ORCPT ); Tue, 24 Nov 2009 15:35:36 -0500 To: Eric Dumazet Cc: David Miller , peter.p.waskiewicz.jr@intel.com, peterz@infradead.org, arjan@linux.intel.com, yong.zhang0@gmail.com, linux-kernel@vger.kernel.org, arjan@linux.jf.intel.com, netdev@vger.kernel.org Subject: Re: [PATCH] irq: Add node_affinity CPU masks for smarter irqbalance hints From: Andi Kleen References: <20091124.093956.247147202.davem@davemloft.net> <1259085412.2631.48.camel@ppwaskie-mobl2> <4B0C2547.8030408@gmail.com> <20091124.105442.06273019.davem@davemloft.net> <4B0C2CCA.6030006@gmail.com> Date: Tue, 24 Nov 2009 21:35:41 +0100 In-Reply-To: <4B0C2CCA.6030006@gmail.com> (Eric Dumazet's message of "Tue, 24 Nov 2009 19:58:18 +0100") Message-ID: <87iqczwtia.fsf@basil.nowhere.org> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1090 Lines: 29 Eric Dumazet writes: > David Miller a ?crit : >> From: Eric Dumazet >> Date: Tue, 24 Nov 2009 19:26:15 +0100 >> >>> It seems complex to me, maybe optimal thing would be to use a NUMA policy to >>> spread vmalloc() allocations to all nodes to get a good bandwidth... >> >> vmalloc() and sk_buff's don't currently mix and I really don't see us >> every allowing them to :-) > > I think Peter was referring to tx/rx rings buffers, not sk_buffs. > > They (ring buffers) are allocated with vmalloc() at driver init time. They are typically allocated with dma_alloc_coherent(), which does allocate a continuous area. In theory you could do interleaving with IOMMus, but just putting it on the same node as the device is probably better. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/