Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934183AbZKXVbN (ORCPT ); Tue, 24 Nov 2009 16:31:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934074AbZKXVbN (ORCPT ); Tue, 24 Nov 2009 16:31:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30832 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934044AbZKXVbM (ORCPT ); Tue, 24 Nov 2009 16:31:12 -0500 Date: Tue, 24 Nov 2009 16:31:05 -0500 From: "Frank Ch. Eigler" To: Andi Kleen Cc: Oleg Nesterov , Alexey Dobriyan , Ananth Mavinakayanahalli , Christoph Hellwig , Ingo@firstfloor.org, "Molnar References: <20091124200220.GA5828@redhat.com> <87my2bwtno.fsf@basil.nowhere.org> <20091124204152.GA9131@redhat.com> <20091124212619.GB29096@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091124212619.GB29096@one.firstfloor.org> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 971 Lines: 28 Hi - On Tue, Nov 24, 2009 at 10:26:19PM +0100, Andi Kleen wrote: > [...] > > For example. tracehook_report_syscall_entry() has a lot of callers > > in arch/, each callsite should be changed to do > > > > if ((task_utrace_flags(current) & UTRACE_EVENT(SYSCALL_ENTRY)) && > > utrace_report_syscall_entry(regs)) > > ret = -1; // this depends on machine > > > > instead of simply calling tracehook_report_syscall_entry(). > > That should be in the utrace code? > > I don't have a problem with having common code somewhere, > just not a whole layer whose only purpose seems to be obfuscation. One man's obfuscation is another man's abstraction. Would you be satisfied if "tracehook_" was renamed "utracehook_"? - FChE -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/