Date: Wed, 25 Nov 2009 00:37:55 +0100
From: Samuel Ortiz <sameo@linux.intel.com>
To: Daniel J Blueman <daniel.blueman@gmail.com>,
       Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] twl4030: fix ELF section mismatch...
Message-ID: <20091124233754.GK8290@sortiz.org>
References: <6278d2220911231054r15891be8k8f8130fd47cddca2@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6278d2220911231054r15891be8k8f8130fd47cddca2@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1155
Lines: 37

On Mon, Nov 23, 2009 at 06:54:06PM +0000, Daniel J Blueman wrote:
> Since twl4030_probe is only called from functions in the init ELF
> section, annotate it so.
> 
> Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>

Mark, thanks for carrying this one with your twl4030 branch.

Cheers,
Samuel.
 
> ---
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index a1c47ee..2fe514d 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -763,7 +763,7 @@ static int twl4030_remove(struct i2c_client *client)
>  }
> 
>  /* NOTE:  this driver only handles a single twl4030/tps659x0 chip */
> -static int
> +static int __init
>  twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  {
>  	int				status;
> -- 
> Daniel J Blueman

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/